Skip to content

show in-progress builds in build queue & build-list pages #2533

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Sep 22, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Jun 24, 2024

Resolves #1011.
( last piece IMO)

this will start showing in-progress builds mainly in:

  • the build queue (linking to the build-list)
  • the build-list for each crate (not linking to any logs).

on top of already redirecting to the build-list when someone tried to access a new in-progress crate.

I'm not 100% certain if we will open up the handlers to some new errors when called on a in-progress crate, but IMO we just have to see and act when there are errors.

One caveat:

Perhaps I'm missing something, but I believe we will have an issue around server restarts and in-progress builds. When we stop / restart our server process we will just stop building without updating our build-status in the database. So we might have "orphaned" in-progress builds.

I'm not sure yet how to solve this the best way, I think the correct solution is a proper graceful shutdown involving rustwide doesn't feel simple. The shutdown would also have to be per build-server, so autoscaling buildservers in the future doesn't reset the build status for builds on other build-servers.

A workaround if we see this happening would probably be to manually reset the build-status for in-progress builds in our deploy-script.

@syphar syphar self-assigned this Jun 24, 2024
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jun 24, 2024
@syphar syphar changed the title in progress builds show in-progress builds in build queue & build pages Jun 24, 2024
@syphar syphar force-pushed the in-progress-builds branch from dc74322 to a9dc5b0 Compare June 24, 2024 13:02
@syphar syphar changed the title show in-progress builds in build queue & build pages show in-progress builds in build queue & build-list pages Jun 24, 2024
@syphar syphar force-pushed the in-progress-builds branch from a9dc5b0 to f19952a Compare June 24, 2024 13:05
@syphar
Copy link
Member Author

syphar commented Jun 24, 2024

some screenshots:

grafik grafik

@syphar syphar marked this pull request as ready for review June 24, 2024 13:07
@syphar syphar requested a review from a team as a code owner June 24, 2024 13:07
@GuillaumeGomez
Copy link
Member

The position of the cog in the second screenshot seems weird, no?

@syphar
Copy link
Member Author

syphar commented Jun 24, 2024

The position of the cog in the second screenshot seems weird, no?

True...

looking at the HTML I have no idea (yet) where this can come from. super odd

@GuillaumeGomez
Copy link
Member

I can take a look if you want. Can you host the webpage with its style somewhere?

@syphar
Copy link
Member Author

syphar commented Jun 26, 2024

I'll not merge this PR before I solved the new sentry errors / panics I'm seeing, that are regressions from #2467

@GuillaumeGomez
Copy link
Member

Hi @syphar. Is the PR ready for a new review?

@syphar
Copy link
Member Author

syphar commented Sep 19, 2024

hey :)

not yet, but it's next on my list to rebase & re-test.

@syphar
Copy link
Member Author

syphar commented Sep 22, 2024

@GuillaumeGomez IMO this is ready for another review.

I rebased, added some fixed, and did a short manual test of some cases.

@syphar
Copy link
Member Author

syphar commented Sep 22, 2024

oh, I see some test failures from my template-filter change, fixing them now

@syphar
Copy link
Member Author

syphar commented Sep 22, 2024

just saw something else I want to change, need to figure out details:

when the latest build is in progress, I think a user probably wants to see the docs for the previous build.

edit: i mean, for the semver match, not for the exact query

@syphar syphar requested review from GuillaumeGomez and removed request for GuillaumeGomez September 22, 2024 08:07
@syphar syphar merged commit ffa296e into rust-lang:master Sep 22, 2024
11 checks passed
@syphar syphar deleted the in-progress-builds branch September 22, 2024 13:01
@syphar syphar added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it labels Sep 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add crates to the database before building them
2 participants