-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade zlib-rs to 0.3.0 to get multiple bugfixes #428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Could you also add GitHub links (essentially the body of the PR) into the commit?
3dc69d9
to
1f78c5c
Compare
I believe the merge commit would have PR description as the commit message anyway. But sure, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this should do it.
If merge-commits would come up in code-lens or similar tools, that should be enough as well. I am not sure they do though.
Would you consider applying the suggestion? Once again I am too afraid to do it myself as it might prevent merging 😅.
also if you actually want to use this, it makes sense to bump the |
Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
I assume @Byron will bump it as part of the usual release process. If not, I'm happy to increment that number, sure. |
Actually, changing the version number will make a release more straightforward. It's a bit like being a genie, limitless power, but impossible to use for yourself :D. |
Version bumped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Fixes at least these correctness issues:
trifectatechfoundation/zlib-rs#165
trifectatechfoundation/zlib-rs#169
trifectatechfoundation/zlib-rs#172
And possibly others.