Skip to content

feat: replace custom u16 le parser with existent rust method #450

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2025
Merged

feat: replace custom u16 le parser with existent rust method #450

merged 1 commit into from
Feb 9, 2025

Conversation

CosminPerRam
Copy link
Contributor

@CosminPerRam CosminPerRam commented Feb 8, 2025 •
edited
Loading

Replaces the custom implementation with the one already provided in the language, they produce the same assembly: before and after.
I also took the liberty to remove the redundant borrows in the function usage.

Byron
Byron approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@Byron Byron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
Thanks also for validating it turns out to be exactly the same!

Note that I am merging despite CI being red, #449 addresses this but I can't merge it myself, waiting for review.

@Byron Byron merged commit 93908ec into rust-lang:main Feb 9, 2025
8 of 14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CosminPerRam @Byron