Skip to content

Re-export some items for select! macro #1405

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2019
Merged

Re-export some items for select! macro #1405

merged 1 commit into from
Jan 14, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 10, 2019 •
edited
Loading

Fixes #1404

select! macro will use the item in futures::{future, task} if imported from futures and the item in futures_util::{future, task} if imported from futures_util. This error was caused by some items not exported in futures_util.

This PR re-exports some items to futures_util, and adds a test of the case where select! macro is imported from futures_util.

@taiki-e
Copy link
Member Author

taiki-e commented Jan 10, 2019 •
edited
Loading

Merging #1407 will fix build failure.

@taiki-e taiki-e mentioned this pull request Jan 10, 2019
Closed
@taiki-e
Copy link
Member Author

taiki-e commented Jan 10, 2019 •
edited
Loading

FYI: 1407 + this PR
(This is the build result of the code which branches from this branch and did git rebase.)

@cramertj
Copy link
Member

Thanks for the fixes!

@cramertj cramertj merged commit 4ff9bb5 into rust-lang:master Jan 14, 2019
@taiki-e taiki-e deleted the select branch January 14, 2019 22:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @cramertj