Allow !Unpin Futures in select! #1873
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for directly `select!`ing on !Unpin Futures as long as those Futures are returned by expressions by stack-pinning the Futures. For the common case where the futures are the result of an `async fn` call this will increase the ergonomics of the macro a lot, since no explicit binding and stack pinning is required. Partially resolves rust-lang#1811 (it does not affect the borrow-checking requirements)
This was referenced Sep 15, 2019
|
This has already been merged as part of #1874 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for directly
select!ing on !Unpin Futures as longas those Futures are returned by expressions by stack-pinning the
Futures.
For the common case where the futures are the result of an
async fncall this will increase the ergonomics of the macro a lot, since no
explicit binding and stack pinning is required.
Partially resolves #1811 (it does not affect the borrow-checking
requirements)