-
Notifications
You must be signed in to change notification settings - Fork 418
WIP: ( feat: create function to allow setting commit_create_cb while rebasing ) #1047
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
WIP: ( feat: create function to allow setting commit_create_cb while rebasing ) #1047
Conversation
I'll make the pipelines pass but I just wanted to get an early review on the approach. |
Just throwing my opinion on here since I was tagged on the issue: I don't think that transmute is safe (the rust parameter types probably don't map cleanly to c ffi). I would use something like this: (example from my job) https://github.com/Vector35/binaryninja-api/blob/dev/rust/src/debuginfo.rs#L181-L246 where Rust puts all of its information into a Box type provided to the userdata (void*) parameter of the callback, and a static callback function which takes the boxed data and interprets it properly. |
|
Thank you for the help @CouleeApps @ehuss |
066ba42
to
494c2b1
Compare
494c2b1
to
5b2d0cb
Compare
@ehuss I've followed an approach similar to the one used in |
Also, I'm testing the changes through an application I have and passing
I've added print statements and ensured that it doesn't reach the Do you know what may be happening? |
Bumping this up |
Fixes #850