Add support for custom allocator #1100
Conversation
| /// This allocator will then be used to make all memory allocations for | ||
| /// libgit2 operations. If the given `allocator` is None, then the | ||
| /// system default will be restored. | ||
| pub unsafe fn set_allocator( |
There was a problem hiding this comment.
For an unsafe fn, we'll need to put a comment here for callers to know how to use it safely
There was a problem hiding this comment.
Alternatively, we don't provide this unsafe binding. People can use libgit2-sys directly at their own risks.
There was a problem hiding this comment.
Yeah, that's a fair point. Would it be better to take an std::alloc::Allocator as an input?
There was a problem hiding this comment.
Maybe, though that is not what I was looked at. I was more on something like, could I call it multiple times? Could I reset after I allocated something in a custom allocator?
reset_search_path has this comment"
This function is unsafe as it mutates the global state but cannot guarantee
thread-safety. It needs to be externally synchronized with calls to access
the global state.
Do we have any considerations on the unsafety of this function?
Add support for the
GIT_OPT_SET_ALLOCATORoption.