Skip to content
This repository was archived by the owner on May 23, 2024. It is now read-only.

Add some ICEs #1525

Merged
merged 3 commits into from
Mar 12, 2023
Merged

Conversation

@JohnTitor
Copy link
Member

rust-lang/rust#108339 doesn't seem like an ICE issue.

@ritikmishra ritikmishra force-pushed the 2023-11-03-add-some-ice branch from 393ea0f to bcba3fe Compare March 12, 2023 08:23
@ritikmishra
Copy link
Contributor Author

my bad - it was supposed to be rust-lang/rust#108399

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
Overall LGTM, fixed style and removed one non-ICE issue.

Some tips for next time:

  • Format code with rustfmt and add the main function if possible; this work is helpful when we move code to rust-lang/rust's regression tests.
  • Check if the issue is already resolved, this can be checked by cargo run

@JohnTitor JohnTitor merged commit 7523a33 into rust-lang:master Mar 12, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants