You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would you consider allowing the use of ^ for negation in addition to !?
gnu coreutils supports the use of ^ in addition to !, based on the behavior of ls and du. I tried finding documentation of this in code, and found this in fnmatch.c
Or perhaps, instead of a direct comparison with '!' at https:/github.com/rust-lang/glob/blob/master/src/lib.rs#L614, can we call a method like is_negation_character? That way, this library can be extended.
The text was updated successfully, but these errors were encountered:
This would also be useful for a project I've been working on, where the incompatibility with Java glob libraries caught us by surprise. I note that @ackerleytng used the workaround of replacing the input string - that would be possible for us too, but it seems like a dangerous thing to do and easy to get wrong.
There doesn't seem to be much momentum behind this issue (even though PR #141 stands ready to fix it), so let me try to impress some urgency by stating, from the sudo-rs project point of view it would be really good to have this fixed. We really don't have any alternatives (sure, we could move to libc for fnmatch, or start maintaining a fork of glob for this one feature, but we obviously don't want to do either of those things).
If there is fear of incompatibility when caret is added, can we modify #141 so that the modifications that @tertsdiepraam proposed are hidden behind a feature flag? That would be perfectly acceptable for us.
Would you consider allowing the use of
^
for negation in addition to!
?gnu coreutils supports the use of
^
in addition to!
, based on the behavior ofls
anddu
. I tried finding documentation of this in code, and found this infnmatch.c
Or perhaps, instead of a direct comparison with
'!'
at https:/github.com/rust-lang/glob/blob/master/src/lib.rs#L614, can we call a method likeis_negation_character
? That way, this library can be extended.The text was updated successfully, but these errors were encountered: