-
Notifications
You must be signed in to change notification settings - Fork 64
Do not keep @mention people on merge commits #100
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
f4e2f07
to
cd37cdf
Compare
5c9f7c7
to
9b16f9e
Compare
Homu uses pytest for tests, maybe you could add a test to make sure the |
That doesn't test escape pings from PR body. Till I don't know if it works as intended. |
Yeah it doesn't test that, but homu doesn't really have a test suite. You could write integration tests for all of it, but like, that's unreasonable to even ask :) Given the current situation with homu tests, I think just testing that function to ensure it doesn't mess output up is enough. |
Done. |
|
||
expect = ( | ||
"r? `@matklad`\n" | ||
"`@bors` r+\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case is unfortunate, but I assume nobody use @bors r+
in PR body.
Hmm, are you sure GitHub doesn't ping if in a commit the mention is inside a code block? My understanding is that GitHub completly ignores markdown there. |
let's try |
I don't receive the pings, do you receive one with bfa1814 ? |
Neither did I! TIL If you remove those two commits we're good to merge this. |
Removed. Thanks for the reviewing! |
I'm not sure it is the right fix or how to test it.
If you could point out, I will give a try.
Closes #99 .