fix: last --jobserver-auth wins
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weihanglo
force-pushed
the
rfind
branch
2 times, most recently
from
57763c7 to
6115c25
Compare
petrochenkov
reviewed
Feb 1, 2024
weihanglo
force-pushed
the
rfind
branch
2 times, most recently
from
311d926 to
bc63299
Compare
56 tasks
From the GNU make manual[^1]: > Be aware that the `MAKEFLAGS` variable may contain multiple > instances of the `--jobserver-auth=` option. > Only the last instance is relevant. Hence this commit makes it so. With this commit, `--jobserver-auth` also takes precedence over `--jobserver-fds`, even when `--jobserver-fds` is the last instance of these flags. This is made intentionally since `--jobserver-fds` was an undocumented internal-only flag before `--jobserver-auth` made public, according to this announcement[^2]. [^1]: https://www.gnu.org/software/make/manual/make.html#Job-Slots [^2]: https://git.savannah.gnu.org/cgit/make.git/tree/NEWS?h=4.2#n31
petrochenkov
approved these changes
Feb 5, 2024
NobodyXu
added a commit
to rust-lang/cc-rs
that referenced
this pull request
Feb 13, 2024
`--jobserver-auth=` is the only documented makeflags. `--jobserver-fds=` is actually an internal only makeflags, so we should always prefer `--jobserver-auth=`. Also, according to doc of makeflags, if there are multiple `--jobserver-auth=` the last one is used ref: rust-lang/jobserver-rs#67 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the GNU make manual1:
Hence this commit makes it so.
With this commit,
--jobserver-authalso takes precedence over--jobserver-fds, even when--jobserver-fdsis the last instanceof these flags. This is made intentionally since
--jobserver-fdswas an undocumented internal-only flag before
--jobserver-authmade public, according to this announcement2.
fixes #66
Footnotes
https://www.gnu.org/software/make/manual/make.html#Job-Slots ↩
https://git.savannah.gnu.org/cgit/make.git/tree/NEWS?h=4.2#n31 ↩