Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add "_aligned_malloc" on windows platform #1839

Merged
merged 1 commit into from
Jul 26, 2020
Merged

Add "_aligned_malloc" on windows platform #1839

merged 1 commit into from
Jul 26, 2020

Conversation

kellda
Copy link
Contributor

@kellda kellda commented Jul 25, 2020

Fixes #953

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

JohnTitor
JohnTitor reviewed Jul 25, 2020
View reviewed changes
@JohnTitor
Copy link
Member

r=me once the commits are squashed.

@kellda kellda force-pushed the _aligned_malloc branch from b96f5a0 to 32b1303 Compare July 25, 2020 20:22
@kellda
Copy link
Contributor Author

kellda commented Jul 25, 2020 •
edited
Loading

Done. Wondering how much

If any changes to this PR are deemed necessary, please add them as extra commits.

is applicable...

JohnTitor
JohnTitor approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor merged commit 04804c7 into rust-lang:master Jul 26, 2020
@kellda kellda deleted the _aligned_malloc branch July 26, 2020 16:42
@Jasper-Bekkers Jasper-Bekkers mentioned this pull request Feb 22, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "_aligned_malloc" on windows platform
3 participants
@kellda @rust-highfive @JohnTitor