Skip to content

Fix multiple symbol definitions on Android CI #2684

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Feb 14, 2022

The breakage was caused by rust-lang/rust#83822 which removed -Wl,--allow-multiple-definition from the Android target linker flags.

@rust-highfive
Copy link

@Amanieu: no appropriate reviewer found, use r? to override

@Amanieu
Copy link
Member Author

Amanieu commented Feb 14, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Feb 14, 2022

📌 Commit eade9ec has been approved by Amanieu

bors added a commit that referenced this pull request Feb 14, 2022
Fix multiple symbol definitions on Android CI

The breakage was caused by rust-lang/rust#83822 which removed `-Wl,--allow-multiple-definition` from the Android target linker flags.
@bors
Copy link
Contributor

bors commented Feb 14, 2022

⌛ Testing commit eade9ec with merge 95a0f8c...

@bors
Copy link
Contributor

bors commented Feb 14, 2022

💔 Test failed - checks-actions

@Amanieu
Copy link
Member Author

Amanieu commented Feb 14, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Feb 14, 2022

📌 Commit ff20d04 has been approved by Amanieu

bors added a commit that referenced this pull request Feb 14, 2022
Fix multiple symbol definitions on Android CI

The breakage was caused by rust-lang/rust#83822 which removed `-Wl,--allow-multiple-definition` from the Android target linker flags.
@bors
Copy link
Contributor

bors commented Feb 14, 2022

⌛ Testing commit ff20d04 with merge 5f8e88a...

@bors
Copy link
Contributor

bors commented Feb 14, 2022

💔 Test failed - checks-cirrus-freebsd-13

@Amanieu
Copy link
Member Author

Amanieu commented Feb 14, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Feb 14, 2022

📌 Commit 95c0d08 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Feb 14, 2022

⌛ Testing commit 95c0d08 with merge acd773d...

@bors
Copy link
Contributor

bors commented Feb 14, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing acd773d to master...

@bors bors merged commit acd773d into rust-lang:master Feb 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants