-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for tvOS #2958
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Add support for tvOS #2958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
JohnTitor
approved these changes
Oct 12, 2022
Thanks! @bors r+ |
bors
added a commit
that referenced
this pull request
Oct 12, 2022
Add support for tvOS This is essentially identical to the iOS support, as the OS is... essentially identical to iOS.
💥 Test timed out |
@bors retry |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Mind cutting a release with this in it at some point soon? I'd like to add tvOS support to libstd. |
Sure, I'll handle it after work. |
Thanks! No rush! |
This was referenced Oct 24, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 21, 2023
Support Apple tvOS in libstd This target has existed in the compiler for a while, was `no_std`-only previously (even requiring `#![feature(restricted_std)]`). Apple tvOS is essentially the same as iOS, down to using the same version numbering, so there's no reason for this to be a `no_std`-only target the way it is currently. Not yet tested much (I have an Apple TV, but haven't tested that this can deploy and run programs on it, nor the simulator). Uses the implementation strategy as the watchOS support in rust-lang#98101 and etc. That is, no `std::os::` interfaces aside from those in `std::os::unix`. Includes an update to libc in order to pull in rust-lang/libc#2958.
Merged
bors
added a commit
that referenced
this pull request
Oct 5, 2023
Fix apple tvos support This PR adds one missed conditional to support apple tvOS target, it complements #2958.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially identical to the iOS support, as the OS is... essentially identical to iOS.