Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Define SO_PROTOCOL and SO_DOMAIN on OpenBSD and Solarish. #3316

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

sunfishcode
Copy link
Member

@sunfishcode sunfishcode commented Aug 9, 2023

This follows the definitions here.

@rustbot
Copy link
Collaborator

rustbot commented Aug 9, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Aug 9, 2023

Some changes occurred in OpenBSD module

cc @semarie

@rustbot
Copy link
Collaborator

rustbot commented Aug 9, 2023

Some changes occurred in solarish module

cc @jclulow, @pfmooney

Copy link
Contributor

@pfmooney pfmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this from an illumos (solarish) perspective.

@sunfishcode sunfishcode changed the title Define SO_PROTOCOL and SO_DOMAIN on OpenBSD. Define SO_PROTOCOL and SO_DOMAIN on OpenBSD and Solarish. Aug 9, 2023
Copy link
Contributor

@semarie semarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for OpenBSD. thanks.

@JohnTitor
Copy link
Member

Thank you for the PR and reviews! @bors r+

@bors
Copy link
Contributor

bors commented Aug 15, 2023

📌 Commit 4e664cc has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 15, 2023

⌛ Testing commit 4e664cc with merge faa087c...

@bors
Copy link
Contributor

bors commented Aug 15, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing faa087c to main...

@bors bors merged commit faa087c into rust-lang:main Aug 15, 2023
@sunfishcode sunfishcode deleted the sunfishcode/openbsd-socket-options branch August 15, 2023 20:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants