-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Define SO_PROTOCOL
and SO_DOMAIN
on OpenBSD and Solarish.
#3316
Define SO_PROTOCOL
and SO_DOMAIN
on OpenBSD and Solarish.
#3316
Conversation
This follows the definitions [here]. [here]: https://github.com/openbsd/src/blob/c5ac8393b86d7549b2b878fd46deeb0e8ee06ae0/sys/sys/socket.h#L116
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred in OpenBSD module cc @semarie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this from an illumos (solarish) perspective.
SO_PROTOCOL
and SO_DOMAIN
on OpenBSD.SO_PROTOCOL
and SO_DOMAIN
on OpenBSD and Solarish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for OpenBSD. thanks.
Thank you for the PR and reviews! @bors r+ |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
This follows the definitions here.