Skip to content

Remove removed items in OpenBSD #3567

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

JohnTitor
Copy link
Member

This removes the removed items in OpenBSD.

@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2024

@JohnTitor: no appropriate reviewer found, use r? to override

@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2024

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in OpenBSD module

cc @semarie

@JohnTitor JohnTitor force-pushed the rm-removed-items-openbsd branch from 5097b81 to 3310fd3 Compare January 29, 2024 20:11
@JohnTitor
Copy link
Member Author

JohnTitor commented Jan 29, 2024

@semarie It'd be great if you could test this against OpenBSD when you have time. If there's anything left I could remove/tweak, feel free to let me know!

@semarie
Copy link
Contributor

semarie commented Jan 30, 2024

the testsuite is fine with it, on OpenBSD -current (upcoming 7.5 at the time).

some remarks:

  • I am unsure about removing syscall() at this point, as 7.5 isn't released yet. So I would maybe only mark it deprecated. But I am fine with removing it too.
  • the starting point for others elements to cleanup, would be to look at test_openbsd():
    • KERN_MAXID, NET_RT_MAXID could be removed (deprecated constants, as there are changing regulary from one release to another)
    • the test for not checking EV_SYSFLAGS could be removed (I don't remember why it is here)
    • the test for not checking mimmutable() function could be removed (the function shows-up in 7.3 which is a latest supported release)

@JohnTitor JohnTitor force-pushed the rm-removed-items-openbsd branch from 3310fd3 to bebfcd7 Compare January 30, 2024 17:07
@JohnTitor JohnTitor force-pushed the rm-removed-items-openbsd branch from bebfcd7 to 790e5c6 Compare January 30, 2024 17:08
@JohnTitor
Copy link
Member Author

JohnTitor commented Jan 30, 2024

Updated as suggested!

  • I am unsure about removing syscall() at this point, as 7.5 isn't released yet. So I would maybe only mark it deprecated. But I am fine with removing it too.

I also think it's fine as the v0.3 release could take some time, let's remove it in this PR (v0.2 still has it).

@semarie
Copy link
Contributor

semarie commented Feb 2, 2024

LGTM. thanks !

@JohnTitor JohnTitor added this pull request to the merge queue Feb 3, 2024
Merged via the queue into rust-lang:main with commit 7d19eed Feb 3, 2024
@bors bors mentioned this pull request Feb 3, 2024
@JohnTitor JohnTitor deleted the rm-removed-items-openbsd branch February 3, 2024 17:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants