Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

attempt to fix #3641 #3647

Merged
merged 1 commit into from
Apr 17, 2024
Merged

attempt to fix #3641 #3647

merged 1 commit into from
Apr 17, 2024

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Apr 2, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@biabbas
Copy link
Contributor

biabbas commented Apr 3, 2024

Libc tests do run with these fix. Thank you @devnexen. An explanation of this fix would be helpful for my understanding. Please provide an explanation.

@devnexen
Copy link
Contributor Author

devnexen commented Apr 3, 2024 •
edited
Loading

Well, those tests were avoided only with musl now we avoid testing those symbols on glibc too. Those discards can be eventually removed once systems are updated at large.

@biabbas
Copy link
Contributor

biabbas commented Apr 3, 2024 •
edited
Loading

Oh. Okay. Thanks you.

@JohnTitor JohnTitor force-pushed the fix_linux_relr_tests branch from 752bb2c to 2e94ad3 Compare April 16, 2024 09:36
@JohnTitor JohnTitor added this pull request to the merge queue Apr 17, 2024
Merged via the queue into rust-lang:main with commit df520eb Apr 17, 2024
41 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 17, 2024
@devnexen @tgross35
attempt to fix rust-lang#3641
a00d7e6 
(backport <rust-lang#3647>)
(cherry picked from commit 2e94ad3)
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 17, 2024
@tgross35 tgross35 mentioned this pull request Nov 17, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 18, 2024
@andrewdavidmackenzie andrewdavidmackenzie mentioned this pull request Nov 26, 2024
Closed
@shadow3aaa shadow3aaa mentioned this pull request Dec 1, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@biabbas biabbas biabbas approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devnexen @rustbot @biabbas @JohnTitor @tgross35