Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix clippy warnings #3855

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix clippy warnings #3855

merged 1 commit into from
Aug 20, 2024

Conversation

youknowone
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Aug 19, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

Thanks! I'll add to stable too if it applies cleanly.

Are there any remaining clippy errors?

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 20, 2024
@tgross35 tgross35 added this pull request to the merge queue Aug 20, 2024
@youknowone
Copy link
Contributor Author

Yes, there are. I didnt fix edition related stuffs because I had no idea which edition is intended for libc

@tgross35
Copy link
Contributor

tgross35 commented Aug 20, 2024 •
edited
Loading

That is a good question that I have been meaning to bring up. I think we will target e2021 on main, it just hasn't been discussed anywhere yet. So good to leave those lints as-is until we have a policy (unless they are forward compatible).

Merged via the queue into rust-lang:main with commit de309f6 Aug 20, 2024
39 checks passed
@youknowone youknowone deleted the fix-clippy branch August 21, 2024 01:30
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
@youknowone @tgross35
fix clippy warnings
291b2a3 
(backport <rust-lang#3855>)
(cherry picked from commit a438a21)
@tgross35 tgross35 mentioned this pull request Aug 28, 2024
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
@youknowone @tgross35
fix clippy warnings
36197e9 
(backport <rust-lang#3855>)
[ drop change to `.split` that doesn't work with old rustc - Trevor ]
(cherry picked from commit a438a21)
@tgross35 tgross35 removed the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 28, 2024
@tgross35
Copy link
Contributor

I was going to backport this but almost all of this doesn't work on our oldest version, so I guess there isn't much need.

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 17, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 18, 2024
@youknowone @tgross35
fix clippy warnings
a0aed5a 
(backport <rust-lang#3855>)
(cherry picked from commit a438a21)
@tgross35 tgross35 mentioned this pull request Nov 18, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 18, 2024
@andrewdavidmackenzie andrewdavidmackenzie mentioned this pull request Nov 26, 2024
Closed
@shadow3aaa shadow3aaa mentioned this pull request Dec 1, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youknowone @rustbot @tgross35 @JohnTitor