Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump libc-test to Rust 2021 Edition #3905

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

eduardosm
Copy link
Contributor

libc-test was already at 2018 Edition, bumping to 2021 just needs changing it in Cargo.toml

@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added this pull request to the merge queue Sep 25, 2024
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@eduardosm
Copy link
Contributor Author

The failure looks unrelated to this PR

#7 [internal] load metadata for docker.io/library/ubuntu:23.10
#7 ERROR: unexpected status from HEAD request to https://registry-1.docker.io/v2/library/ubuntu/manifests/23.10: 401 Unauthorized
------
 > [internal] load metadata for docker.io/library/ubuntu:23.10:
------
Dockerfile:1
--------------------
   1 | >>> FROM ubuntu:23.10
   2 |     RUN apt-get update
   3 |     RUN apt-get install -y --no-install-recommends \
--------------------
ERROR: failed to solve: ubuntu:23.10: failed to resolve source metadata for docker.io/library/ubuntu:23.10: unexpected status from HEAD request to https://registry-1.docker.io/v2/library/ubuntu/manifests/23.10: 401 Unauthorized

@tgross35
Copy link
Contributor

Yeah, I'll retry. Weird that it doesn't give any sort of notification for failures...

@tgross35 tgross35 added this pull request to the merge queue Sep 26, 2024
Merged via the queue into rust-lang:main with commit 09d7aa0 Sep 26, 2024
41 checks passed
@eduardosm eduardosm deleted the libc-test-edition-2021 branch September 26, 2024 17:06
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 6, 2024
@tgross35 tgross35 mentioned this pull request Nov 6, 2024
@tgross35 tgross35 added stable-declined This change is breaking, difficult to backport, low priority, or otherwise not relevant for 0.2 and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 6, 2024
@tgross35 tgross35 added stable-nominated This PR should be considered for cherry-pick to libc's stable release branch and removed stable-declined This change is breaking, difficult to backport, low priority, or otherwise not relevant for 0.2 labels Nov 16, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 16, 2024
@tgross35 tgross35 mentioned this pull request Nov 16, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants