Skip to content

linux: Make elf name type constants always available #3938

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

SteveLauC
Copy link
Contributor

@SteveLauC SteveLauC commented Sep 22, 2024

What does this PR do

Adds some register set values for Linux/musl

Linux header: https://github.com/torvalds/linux/blob/88264981f2082248e892a706b2c5004650faac54/include/uapi/linux/elf.h#L378-L382


We can port this patch to the libc-0.2 branch.

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

Thanks for the PR! Are these also available through glibc? If so they should probably just go to linux/mod.rs (if not then lgtm).

@SteveLauC
Copy link
Contributor Author

Are these also available through glibc?

Yeah, we already have them in gnu/mod.rs, considering that they are directly defined in the kernel, I guess they are available on all the libcs (Not quite sure, let's test this with our CI).

If so they should probably just go to linux/mod.rs

Let me give this a try:)

@SteveLauC SteveLauC force-pushed the feat/regs_linux_musl branch 2 times, most recently from eddedde to e40526a Compare October 1, 2024 00:35
@SteveLauC
Copy link
Contributor Author

Let me give this a try:)

Done:)

@tgross35 tgross35 force-pushed the feat/regs_linux_musl branch from e40526a to 571b37c Compare October 1, 2024 02:01
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 1, 2024
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 changed the title feat: some register set value for linux/musl linux: Make elf name type constants always available Oct 1, 2024
@tgross35
Copy link
Contributor

tgross35 commented Oct 1, 2024

Docs for reference https://man7.org/linux/man-pages/man5/elf.5.html

@tgross35 tgross35 enabled auto-merge October 1, 2024 02:09
@tgross35 tgross35 added this pull request to the merge queue Oct 1, 2024
Merged via the queue into rust-lang:main with commit 4ce03da Oct 1, 2024
41 checks passed
@SteveLauC SteveLauC deleted the feat/regs_linux_musl branch October 1, 2024 03:41
@tgross35 tgross35 mentioned this pull request Oct 15, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants