Fix "struct stat" on 32-bit FreeBSD 12+ #3939
Conversation
Commit 7437d0a erroneously defined it as "ulong" instead of u64. Nobody noticed the mistake, probably because it was only tested on 64-bit architectures, where those are equivalent. But it's a problem now, after rust-lang#3723 , which switched the standard library to a FreeBSD 12 ABI. Issue rust-lang/rust#130677
The original definitions were never correct. But nobody noticed because we don't do CI on 32-bit FreeBSD. The problem is apparent now due to rust-lang#3723 , which caused the nightly toolchain to switch to a FreeBSD 12 ABI. Fixes rust-lang/rust#130677
asomers
force-pushed
the
i386-fbsd12.2
branch
from
3f23a7b to
8aca9c0
Compare
|
Thanks for the fix, can this target |
We'll need to merge it to both branches, but there's a slight conflict with main. As for headers: |
|
Thanks for the links, easy enough. For future reference I've been preferring PRs to target @rustbot label +main-needs-cherry-pick |
rustbot
added
the
main-needs-cherry-pick
tgross35
added
main-applied
* Fix the definition of ino_t on 32-bit FreeBSD 12+ Commit 7437d0a erroneously defined it as "ulong" instead of u64. Nobody noticed the mistake, probably because it was only tested on 64-bit architectures, where those are equivalent. But it's a problem now, after rust-lang#3723 , which switched the standard library to a FreeBSD 12 ABI. Issue rust-lang/rust#130677 * Fix the definition of "struct stat" on 32-bit FreeBSD 12+ The original definitions were never correct. But nobody noticed because we don't do CI on 32-bit FreeBSD. The problem is apparent now due to rust-lang#3723 , which caused the nightly toolchain to switch to a FreeBSD 12 ABI. Fixes rust-lang/rust#130677 * fixup: fix build on powerpc, powerpc64, and arm
It has always been broken. But we never noticed because we don't run CI on 32-bit FreeBSD, and until #3723 our users always used a FreeBSD 11 ABI.
Fixes rust-lang/rust#130677