hurd: Add domainname field to utsname #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
158cd30 ("hurd: fix definition of utsname struct") dropped it saying it is unused, but it is still there and read by the platform-info crate, whose build thus got broken. It is less troublesome to just declare the field.
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
|
@rustbot label +stable-nominated |
rustbot
added
the
stable-nominated
tgross35
approved these changes
Nov 18, 2024
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 19, 2024
158cd30 ("hurd: fix definition of utsname struct") dropped it saying it is unused, but it is still there and read by the platform-info crate, whose build thus got broken. It is less troublesome to just declare the field. (backport <rust-lang#4089>) (cherry picked from commit b3562e1)
Merged
tgross35
added
stable-applied
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
158cd30 ("hurd: fix definition of utsname struct") dropped it saying it is unused, but it is still there and read by the platform-info crate, whose build thus got broken. It is less troublesome to just declare the field.
Description
This restores a field that was removed but is actually read.
Sources
https://sourceware.org/git/?p=glibc.git;a=blob;f=posix/sys/utsname.h;h=c6884255e04595996dbbc337ac667d0defd035f3;hb=HEAD#l66
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI