Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ci: add support for loongarch64-unknown-linux-musl #4092

Merged
merged 2 commits into from
Nov 19, 2024
Merged

ci: add support for loongarch64-unknown-linux-musl #4092

merged 2 commits into from
Nov 19, 2024

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Nov 18, 2024

Description

  1. Fix libc-tests for loongarch64-unknown-linux-musl.
  2. Add support for loongarch64-unknown-linux-musl target in CI.

Sources

None.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35
tgross35 reviewed Nov 18, 2024
View reviewed changes
@tgross35
Copy link
Contributor

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 18, 2024
@tgross35 tgross35 mentioned this pull request Nov 18, 2024
Closed
3 tasks
tgross35
tgross35 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm trying to land some large formatting cleanup in #4107, please rebase after that merges.

@heiher
Copy link
Contributor Author

heiher commented Nov 19, 2024

LGTM. I'm trying to land some large formatting cleanup in #4107, please rebase after that merges.

OK. Thanks.

@tgross35 tgross35 enabled auto-merge November 19, 2024 04:37
@tgross35 tgross35 added this pull request to the merge queue Nov 19, 2024
Merged via the queue into rust-lang:main with commit 96c197c Nov 19, 2024
45 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 19, 2024
@heiher @tgross35
Fix libc-tests for loongarch64-linux-musl
91989b6 
(backport <rust-lang#4092>)
(cherry picked from commit bfdc370)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 19, 2024
@heiher @tgross35
ci: add support for loongarch64-unknown-linux-musl
ef39104 
(backport <rust-lang#4092>)
(cherry picked from commit e03b594)
@tgross35 tgross35 mentioned this pull request Nov 19, 2024
Merged
@bors bors mentioned this pull request Nov 19, 2024
Merged
3 tasks
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
A-CI Area: CI-related items O-linux O-musl O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heiher @rustbot @tgross35