-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Cygwin: Add PTY and group API #4309
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
I see Assuming so, lgtm. Please update the description / commit message to say what actually changed (Nix requires a lot of things) |
Yes, it's the correct source. I'll update the commit message later. I tested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I updated the links in the description.
@rustbot label +stable-nominated
* `forkpty` & `openpty`: for nix::pty * `getgrgid_r`, `getgrouplist`, getgrnam_r`, `initgroups`: for `user` feature of `nix::unistd`
* `forkpty` & `openpty`: for nix::pty * `getgrgid_r`, `getgrouplist`, getgrnam_r`, `initgroups`: for `user` feature of `nix::unistd` (backport <rust-lang#4309>) [ update message to mention Cygwin - Trevor ] (cherry picked from commit 3dd7092)
* `forkpty` & `openpty`: for nix::pty * `getgrgid_r`, `getgrouplist`, getgrnam_r`, `initgroups`: for `user` feature of `nix::unistd` (backport <rust-lang#4309>) [ update message to mention Cygwin - Trevor ] (cherry picked from commit 3dd7092)
Description
Some methods required by
nix
crate.Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI