Skip to content

cygwin: add statfs & fcntl #4321

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

Berrysoft
Copy link
Contributor

@Berrysoft Berrysoft commented Mar 11, 2025

Description

Needed by rustix support:

  • statfs, fstatfs, and struct statfs
  • posix_fadvise, posix_fallocate, fallocate, and constants

Sources

https://github.com/cygwin/cygwin/blob/8e2da4b223936bbf3329d5dd1658429b30b6d50d/winsup/cygwin/include/sys/vfs.h
https://github.com/cygwin/cygwin/blob/8e2da4b223936bbf3329d5dd1658429b30b6d50d/winsup/cygwin/include/fcntl.h

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

Needed by rustix support:

* statfs, fstatfs, and struct statfs
* posix_fadvise, posix_fallocate, fallocate, and constants
@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 11, 2025
@tgross35 tgross35 added this pull request to the merge queue Mar 11, 2025
@tgross35
Copy link
Contributor

Updated the top post's links to permalinks, those are preferred in case implementations move/change

Merged via the queue into rust-lang:main with commit 094464b Mar 11, 2025
43 checks passed
@Berrysoft Berrysoft deleted the cygwin-rustix branch March 12, 2025 01:41
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
Needed by rustix support:

* statfs, fstatfs, and struct statfs
* posix_fadvise, posix_fallocate, fallocate, and constants

(backport <rust-lang#4321>)
(cherry picked from commit f007c3e)
@tgross35 tgross35 mentioned this pull request Apr 3, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants