Define SO_BINDTOIFINDEX on Android #4391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in the Android module cc @maurer |
rustbot
added
the
stable-nominated
maurer
approved these changes
Apr 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Apr 11, 2025
Android supports SO_BINDTOIFINDEX since SDK level 31: https://cs.android.com/android/platform/superproject/main/+/main:prebuilts/vndk/v31/arm/include/bionic/libc/kernel/uapi/asm-generic/socket.h;l=88;drc=684b16d3ce1e891ebe15d5678e12fa05ee6dd6e4 (backport <rust-lang#4391>) (cherry picked from commit efc6949)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Apr 11, 2025
Android supports SO_BINDTOIFINDEX since SDK level 31: https://cs.android.com/android/platform/superproject/main/+/main:prebuilts/vndk/v31/arm/include/bionic/libc/kernel/uapi/asm-generic/socket.h;l=88;drc=684b16d3ce1e891ebe15d5678e12fa05ee6dd6e4 (backport <rust-lang#4391>) (cherry picked from commit efc6949)
tgross35
added
stable-applied
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android supports SO_BINDTOIFINDEX since SDK level 31: https://cs.android.com/android/platform/superproject/main/+/main:prebuilts/vndk/v31/arm/include/bionic/libc/kernel/uapi/asm-generic/socket.h;l=88;drc=684b16d3ce1e891ebe15d5678e12fa05ee6dd6e4
Description
Android supports SO_BINDTOIFINDEX since SDK level 31, which is introduced to support kernel v5.1.3.
Fixes: #4390
Sources
Android: Earliest support since SDK level 31: https://cs.android.com/android/platform/superproject/main/+/main:prebuilts/vndk/v31/arm/include/bionic/libc/kernel/uapi/asm-generic/socket.h;l=88;drc=684b16d3ce1e891ebe15d5678e12fa05ee6dd6e4
Current support in bionic: https://cs.android.com/android/platform/superproject/main/+/main:bionic/libc/kernel/uapi/asm-generic/socket.h;l=76;drc=65552ba5db8f299144172d4464350f1363a95304
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI