Skip to content

Cleanup IOCTL definitions in linux_like tree #4418

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cleanup IOCTL definitions in linux_like tree #4418

wants to merge 1 commit into from

Conversation

jjanowsk
Copy link
Contributor

@jjanowsk jjanowsk commented Apr 15, 2025 •
edited
Loading

Description

Cleanup IOCTL definitions in linux_like tree

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jjanowsk jjanowsk force-pushed the if_tun_ioctls_refactor branch 2 times, most recently from d600ca5 to ff04f46 Compare April 15, 2025 15:29
@jjanowsk jjanowsk marked this pull request as ready for review April 16, 2025 08:28
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2025

Some changes occurred in the Android module

cc @maurer

tgross35
tgross35 approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is so nice, +179/-525 is a great diff. Thank you for putting this together!

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Apr 25, 2025
@tgross35 tgross35 added this pull request to the merge queue Apr 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2025
@tgross35 tgross35 force-pushed the if_tun_ioctls_refactor branch from ff04f46 to 28d80ed Compare April 25, 2025 07:34
tgross35
tgross35 requested changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, looks like this needs to pick up a few recent additions that have merged since this was created. Would you be able to update this?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tgross35 tgross35 tgross35 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@tgross35 tgross35

Labels
O-android O-gnu O-linux O-linux-like O-mips O-sparc O-unix S-waiting-on-author stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjanowsk @rustbot @tgross35