Skip to content

Add constants from linux/cn_proc.h and linux/connector.h #4434

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Bben01
Copy link

@Bben01 Bben01 commented Apr 30, 2025

Description

Add constants from linux/cn_proc.h and linux/connector.h

Sources

https://github.com/torvalds/linux/blob/b6ea1680d0ac0e45157a819c41b46565f4616186/include/uapi/linux/cn_proc.h
https://github.com/torvalds/linux/blob/b6ea1680d0ac0e45157a819c41b46565f4616186/include/uapi/linux/connector.h

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see rust-lang/libc#3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot rustbot added O-linux O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 30, 2025
@Bben01
Copy link
Author

Bben01 commented Apr 30, 2025

I think that the CI is failing on i686-unknown-linux-gnu because it didn't find the header files. What should I do to fix that?

@tgross35
Copy link
Contributor

tgross35 commented May 9, 2025

If these are more recent than our kernel versions in CI, you will need to update libc-test/build.rs to skip them with a FIXME. If you do this, just make sure libc-test passes locally without the skips (assuming you have a newer version locally).

@rustbot author

@rustbot
Copy link
Collaborator

rustbot commented May 9, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Bben01 Bben01 force-pushed the feature/add-connector-constants branch 4 times, most recently from 3dd6220 to c1044df Compare May 9, 2025 14:31
@Bben01 Bben01 force-pushed the feature/add-connector-constants branch from c1044df to 60e12f7 Compare May 9, 2025 14:40
@Bben01
Copy link
Author

Bben01 commented May 9, 2025

I don't know why the style check fails. It says to replace the = with : in the c_enum, but the macro cannot accept :

help: replace equals symbol with a colon
     |
4760 -         PROC_EVENT_EXIT = 0x80000000,
4760 +         PROC_EVENT_EXIT: 0x80000000,

@rustbot ready

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
O-linux O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants