-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Extern crate #2503
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Extern crate #2503
Conversation
… overoptimize compile time.
Also refactor the `mdBook test` section and add a new "writing doc tests" chapter.
I'm dependent on feature file_set_times, which was stabilized in rust v 1.76. You are currently on 1.74. What is the schedule for updating your MSRV? |
… project: changed config rust.package-dir to rust.manifest
and preferring [rust.manifest] over [rust.edition].
make chap Alternate Backends pass doctest.
Functionally, I think this PR is now stable and ready for review (and general use). |
Prefer edition setting from Cargo.toml over book.toml; sadly, Cargo also overrides command line.
guide/src/guide/README.md
Outdated
@@ -4,4 +4,4 @@ This user guide provides an introduction to basic concepts of using mdBook. | |||
|
|||
- [Installation](installation.md) | |||
- [Reading Books](reading.md) | |||
- [Creating a Book](creating.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this am accident?
In fixing above issues, I noticed that there were clippy nags in several files that hadn't been raised by CI. I've fixed the ones in files I modified and could fix the remaining ones if needed, but I don't know why CI doesn't flag them. |
☔ The latest upstream changes (possibly #2681) made this pull request unmergeable. Please resolve the merge conflicts. |
Allows doc tests to freely reference external crates in
use
statements.Avoids depending on unstable Cargo interfaces to determine dependencies by the
simple expedient of running a
cargo build --verbose
and observing how Cargo invoked the compiler.Includes necessary doc changes and some gratuitous rewrites as well.
Fixes #706 and #394.
Edit: does not address issue 768.
Edit: With the latest batch of commits, all doctests in the
mdbook
project now work.