Skip to content

Make base_url available for .hbs to set base href if configured. #2509

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make base_url available for .hbs to set base href if configured. #2509

wants to merge 1 commit into from

Conversation

prasad83
Copy link

When site_url is configured make it available for hbs to set base href (using base_url)

@prasad83
Make base_url available for .hbs to set base href if configured.
bff40ef 
When site_url is configured make it available for hbs to set base href (using base_url)
@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Dec 20, 2024
@prasad83
Copy link
Author

Without this change I had to make workaround as follows:

theme/head.hbs

{{#if live_reload_endpoint}}
<!-- local run -->
{{else}}
<base href="https://website.url/">
{{/if}}

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasad83 @rustbot