Skip to content

Fix sidebar links to use absolute paths to prevent 404 errors #2730

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madyankin
Copy link

This change makes all sidebar navigation links absolute paths (starting with '/') instead of relative paths, preventing duplicate path segments when navigating between nested pages.

Added test to verify all sidebar links are absolute paths.

Fixes #1764

This change makes all sidebar navigation links absolute paths (starting with '/') instead of relative paths, preventing duplicate path segments when navigating between nested pages.

Added test to verify all sidebar links are absolute paths.

Fixes rust-lang#1764
@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Jun 13, 2025
@ehuss
Copy link
Contributor

ehuss commented Jun 15, 2025

I don't think this approach will work, since the book may not be rooted at any specific URL path. I believe something more along the lines of #1802.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

site-url not respected in links
3 participants