Skip to content

ABI checks do not accept Option-"like" types #3983

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
RalfJung opened this issue Oct 21, 2024 · 1 comment · Fixed by rust-lang/rust#132057
Closed

ABI checks do not accept Option-"like" types #3983

RalfJung opened this issue Oct 21, 2024 · 1 comment · Fixed by rust-lang/rust#132057

Comments

@RalfJung
Copy link
Member

Recently we ratified the Option null-pointer guarantee to also apply to Option-like types. Miri should be adjusted to match that.

joboet added a commit to joboet/rust that referenced this issue Nov 7, 2024
…wiser

miri: update ABI compat checks to accept Option-like types

This implements the t-lang decision described [here](rust-lang#130628 (comment)).

Fixes rust-lang/miri#3983
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 7, 2024
Rollup merge of rust-lang#132057 - RalfJung:miri-abi-compat, r=wesleywiser

miri: update ABI compat checks to accept Option-like types

This implements the t-lang decision described [here](rust-lang#130628 (comment)).

Fixes rust-lang/miri#3983
@RalfJung
Copy link
Member Author

RalfJung commented Nov 7, 2024

Fixed by rust-lang/rust#132057

@RalfJung RalfJung closed this as completed Nov 7, 2024
github-actions bot pushed a commit that referenced this issue Nov 9, 2024
miri: update ABI compat checks to accept Option-like types

This implements the t-lang decision described [here](rust-lang/rust#130628 (comment)).

Fixes #3983
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant