Skip to content

Add #[allow(unreachable_code)] to drop(x) in tests/run-pass/generator.rs #1877

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from Aug 24, 2021
Merged

Add #[allow(unreachable_code)] to drop(x) in tests/run-pass/generator.rs #1877

merged 1 commit into from Aug 24, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2021

The test starts to trigger this warning (I guess it's caused by rust-lang/rust#85556). The warning seems correct, but the unreachable code in that test also seems reasonable.

@ghost ghost changed the title Add #[allow(unreachable_code)] to drop(x) in `tests/run-pass/gene… Add #[allow(unreachable_code)] to drop(x) in tests/run-pass/generator.rs Aug 24, 2021
@RalfJung
Copy link
Member

Makes sense, thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2021

📌 Commit 33a67c6 has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Aug 24, 2021

⌛ Testing commit 33a67c6 with merge 08ca560...

@bors
Copy link
Contributor

bors commented Aug 24, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 08ca560 to master...

@bors bors merged commit 08ca560 into rust-lang:master Aug 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants