do not protect SRW items #2248
Merged
do not protect SRW items #2248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also do more iterations of weak mem consistency, since now that is no longer the slowest test ;)
|
Assuming the FCP in rust-lang/rust#98017 will pass, let's land this. |
|
📌 Commit 1b214a0 has been approved by |
|
☀️ Test successful - checks-actions |
RalfJung
added a commit
to RalfJung/unsafe-code-guidelines
that referenced
this pull request
Jun 22, 2022
See rust-lang/miri#2248 for the Miri change.
This was referenced Jun 26, 2022
bors bot
added a commit
to crossbeam-rs/crossbeam
that referenced
this pull request
Jun 30, 2022
855: Miri: enable preemption again r=taiki-e a=RalfJung Miri has a [work-around](rust-lang/miri#2248) for rust-lang/rust#55005 now. Also, "check-number-validity" is on by default these days. And I am not sure why "compare-exchange-weak-failure-rate=0.0" was set so let's see what happens when we remove it. :) Co-authored-by: Ralf Jung <post@ralfj.de>
bors bot
added a commit
to crossbeam-rs/crossbeam
that referenced
this pull request
Jul 1, 2022
855: Miri: enable preemption again r=taiki-e a=RalfJung Miri has a [work-around](rust-lang/miri#2248) for rust-lang/rust#55005 now. Also, "check-number-validity" is on by default these days. And I am not sure why "compare-exchange-weak-failure-rate=0.0" was set so let's see what happens when we remove it. :) 858: Ignore clippy::let_unit_value lint r=taiki-e a=taiki-e Co-authored-by: Ralf Jung <post@ralfj.de> Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot
added a commit
to crossbeam-rs/crossbeam
that referenced
this pull request
Jul 1, 2022
855: Miri: enable preemption again r=taiki-e a=RalfJung Miri has a [work-around](rust-lang/miri#2248) for rust-lang/rust#55005 now. Also, "check-number-validity" is on by default these days. And I am not sure why "compare-exchange-weak-failure-rate=0.0" was set so let's see what happens when we remove it. :) 858: Ignore clippy::let_unit_value lint r=taiki-e a=taiki-e Co-authored-by: Ralf Jung <post@ralfj.de> Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors
added a commit
that referenced
this pull request
Jul 3, 2022
move arc_drop test to miri-test-libstd That's where we have a bunch of slow and unlikely-to-regress tests already. Miri's test suite should primarily test Miri; we sometimes add libstd tests when they are cheap and/or exercise interesting code paths in Miri. #2248 already ensures that we allow code like `Arc` with more direct tests.
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Miri version of rust-lang/rust#98017.