doc: improve documentation of packed type layout modifier #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
reviewed
Oct 11, 2021
phip1611
force-pushed
the
doc-fix-repr-packed
branch
2 times, most recently
from
ebdd236 to
20d86cd
Compare
|
I updated the PR @ehuss . See the latest version here: https://github.com/rust-lang/nomicon/blob/20d86cd0331e1c54bfd85e25326e3e0e41fc979e/src/other-reprs.md Any more comments? |
ehuss
reviewed
Nov 12, 2021
phip1611
force-pushed
the
doc-fix-repr-packed
branch
from
c28f75e to
305ffdc
Compare
|
Sorry for the circumstances on this, I obviously understood something wrong. I tried to improve the description in a way, |
phip1611
force-pushed
the
doc-fix-repr-packed
branch
from
305ffdc to
ae11a44
Compare
phip1611
changed the title
phip1611
force-pushed
the
doc-fix-repr-packed
branch
from
ae11a44 to
93760d4
Compare
phip1611
commented
Dec 8, 2021
| side-effects. | ||
|
|
||
| In particular, most architectures *strongly* prefer values to be aligned. This | ||
| may mean the unaligned loads are penalized (x86), or even fault (some ARM | ||
| chips). For simple cases like directly loading or storing a packed field, the |
There was a problem hiding this comment.
I can remove this from the PR if you want. This was necessary so that each paragraph has roughly the same width in the markdown file.
phip1611
commented
Jan 2, 2022
phip1611
force-pushed
the
doc-fix-repr-packed
branch
from
93760d4 to
fbb0bab
Compare
|
@ehuss I rebased the PR branch onto the latest master branch. |
phip1611
force-pushed
the
doc-fix-repr-packed
branch
from
fbb0bab to
eab859a
Compare
This commit improves the description of the packed type layout modifier.
phip1611
force-pushed
the
doc-fix-repr-packed
branch
from
eab859a to
c17dd17
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust language reference (and my experience, proved by tests) says, thatpacked(n)gives you the ability to align the struct too. This bug probably comes from a past version of Rust, where this wasn't supported.Currently, the packed documentation doesn't mention the n-parameter.
https://doc.rust-lang.org/reference/type-layout.html