Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

cleaned up some styles, shifted to red links, unified logo and sales pit... #2

Closed
wants to merge 1 commit into from

Conversation

dustinlacewell
Copy link

...ch, added subtle texture, sectional content minimally styled.

…pitch, added subtle texture, sectional content minimally styled.
@brson
Copy link
Contributor

brson commented Nov 6, 2012

Thanks!

Some things that bother me about the current web site:

  • The sales pitch is the most prominent feature of the page, but isn't great. It states some things that are self-evident from the feature list and example. As the first thing somebody might read about Rust it can be more convincing.
  • The color scheme use for the code example doesn't have anything to do with the site theme - it's just the default code mirror theme.
  • There is a lot of whitespace that, while not bad, makes the page as a whole a little unbalanced.

Additional considerations:

  • The style used on the web site also needs to be taken into account for the other docs. They don't currently share a stylesheet, but do have some common styling, like font choice, link colors, element spacing.

The proposed design fixes the whitespace issues. The sales pitch is still using some placeholder text that I am not satisfied with. It doesn't address the code colors.

In general I would describe this design as more agressive or 'severe' than the current one, with sharper corners, warm colors, more italics, and more gray. I like it less overall.

As to the color scheme, I am inclined to move to warmer colors, as warmer colors are move evocative of 'rust' - seems to make sense. It's hard for me to know what to think of the pinkish color here because there are 4 different, mostly unrelated shades of red on the page: the link color, the hover color, the string syntax highlighting color, and the github banner. It is not consistent.

All three columns have a different top edge, illustrated here: http://imgur.com/hN07l,MYQ9u#0. Seems arbitrary. Similarly, with borders around the third column, the bottom edge doesn't align with the middle column. It's not clear to me that that's a bad thing, but it might be.

The vertical gutters between sections are different widths than the horizontal: http://imgur.com/kYfyO

I'm not crazy about the pinstripe background texture, though it is very subtle. It mostly makes my screen look dirty. Maybe something without such an obvious pattern would work better.

The thing I like the most about this is the way the Rust logo is merged with one of the columns: http://imgur.com/hN07l,MYQ9u#1. It's a promising idea, but has some issues, the primary of which is that I don't like the black top border in the other contexts. The logo also isn't particularly integrated with the column's style, the background color and line extending though the logo background in a seemingly arbitrary manner: http://imgur.com/HDZNq

The right-justification on the lefthand column of the features list works well, though there is very little margin on the left. The zebra stripes add more visual noise and makes page overall very gray.

@brson brson closed this Apr 1, 2013
brson referenced this pull request in brson/rust-www Oct 22, 2015
Tweaks to the community and user groups page
aturon pushed a commit to aturon/rust-www that referenced this pull request Jan 14, 2016
steveklabnik pushed a commit that referenced this pull request Oct 10, 2016
alexcrichton pushed a commit that referenced this pull request Feb 14, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants