Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Get information out of Span #44

Closed
celinval opened this issue Oct 10, 2023 · 1 comment
Closed

Get information out of Span #44

celinval opened this issue Oct 10, 2023 · 1 comment
Assignees
@ouz-a

Comments

@celinval
Copy link
Contributor

celinval commented Oct 10, 2023 •
edited by rustbot
Loading

Provide an API that users can use to retrieve specific information of a Span, such as filename, line number.
@ouz-a
Copy link

ouz-a commented Oct 11, 2023 •
edited
Loading

Well I'm not entirely sure in which format you want line numbers(a struct, opaque), but this should be easy enough.
@rustbot claim

@ouz-a ouz-a mentioned this issue Oct 11, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 13, 2023
@matthiaskrgr
Rollup merge of rust-lang#116630 - ouz-a:smir_span_better, r=oli-obk
c7e8464 
Add ability to get lines/filename for Span in smir

Wasn't sure about how to structure lines, so went with safest option, also I'm not sure why `span_to_lines` returns `vec`.

Addresses rust-lang/project-stable-mir#44

r? `@oli-obk`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 14, 2023
@matthiaskrgr
Rollup merge of rust-lang#116630 - ouz-a:smir_span_better, r=oli-obk
3890ba9 
Add ability to get lines/filename for Span in smir

Wasn't sure about how to structure lines, so went with safest option, also I'm not sure why `span_to_lines` returns `vec`.

Addresses rust-lang/project-stable-mir#44

r? ``@oli-obk``
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 14, 2023
@rust-timer
Unrolled build for rust-lang#116630
2e86ba8 
Rollup merge of rust-lang#116630 - ouz-a:smir_span_better, r=oli-obk

Add ability to get lines/filename for Span in smir

Wasn't sure about how to structure lines, so went with safest option, also I'm not sure why `span_to_lines` returns `vec`.

Addresses rust-lang/project-stable-mir#44

r? ``@oli-obk``
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ouz-a ouz-a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@celinval @ouz-a