Skip to content

Add a method to get the FnAbi of a function pointer #63

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
celinval opened this issue Feb 22, 2024 · 3 comments · Fixed by rust-lang/rust#126722
Open

Add a method to get the FnAbi of a function pointer #63

celinval opened this issue Feb 22, 2024 · 3 comments · Fixed by rust-lang/rust#126722
Assignees
@adwinwhite
Labels
good first issue Good for newcomers

Comments

@celinval
Copy link
Contributor

celinval commented Feb 22, 2024 •
edited by rustbot
Loading

We have added a method to get the function ABI of an instance, however, that doesn't work for function pointers. We should consider adding a similar API to the query fn_abi_of_fn_ptr(/*..*/).
@oli-obk
Copy link
Contributor

oli-obk commented Feb 22, 2024

function pointer types have a fn sig field https://doc.rust-lang.org/nightly/nightly-rustc/stable_mir/ty/struct.FnSig.html that contains the ABI.

@celinval
Copy link
Contributor Author

celinval commented Feb 22, 2024 •
edited
Loading

That just represents the ABI type not the argument's ABI though. I changed the title of this issue to avoid any confusion. Sorry about that!

@celinval celinval changed the title Add a method to get the ABI of a function pointer Add a method to get the FnAbi of a function pointer Feb 22, 2024
@celinval celinval added the good first issue Good for newcomers label Mar 1, 2024
@adwinwhite
Copy link

@rustbot claim

@adwinwhite adwinwhite mentioned this issue Jun 20, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jun 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#126722 - adwinwhite:ptr_fn_abi, r=celinval
e843355 
Add method to get `FnAbi` of function pointer

Provide a StableMIR API to query `FnAbi` of a function pointer.

Fixes [rust-lang/project-stable-mir#63](rust-lang/project-stable-mir#63)
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Jun 22, 2024
@workingjubilee
Rollup merge of rust-lang#126722 - adwinwhite:ptr_fn_abi, r=celinval
1f9793f 
Add method to get `FnAbi` of function pointer

Provide a StableMIR API to query `FnAbi` of a function pointer.

Fixes [rust-lang/project-stable-mir#63](rust-lang/project-stable-mir#63)
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jun 22, 2024
@rust-timer
Unrolled build for rust-lang#126722
008605b 
Rollup merge of rust-lang#126722 - adwinwhite:ptr_fn_abi, r=celinval

Add method to get `FnAbi` of function pointer

Provide a StableMIR API to query `FnAbi` of a function pointer.

Fixes [rust-lang/project-stable-mir#63](rust-lang/project-stable-mir#63)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@adwinwhite adwinwhite

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add method to get FnAbi of function pointer adwinwhite/rust
3 participants
@oli-obk @celinval @adwinwhite