Skip to content

Does not compile on 1.39.0 #685

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
goffrie opened this issue May 28, 2020 · 2 comments
Closed

Does not compile on 1.39.0 #685

goffrie opened this issue May 28, 2020 · 2 comments

Comments

@goffrie
Copy link
Contributor

goffrie commented May 28, 2020

#673 seems to have caused regex to stop compiling on rust 1.39.0 (and maybe other versions):

error[E0658]: `cfg(doctest)` is experimental and subject to change
   --> src/lib.rs:625:7
    |
625 | #[cfg(doctest)]
    |       ^^^^^^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/62210

It actually does work on the MSRV 1.28.0 though, presumably since the feature hadn't even been conceived yet and so wasn't unstable :p
@goffrie goffrie mentioned this issue May 28, 2020
Merged
@BurntSushi
Copy link
Member

This was hinted at in #684 and...

It actually does work on the MSRV 1.28.0 though, presumably since the feature hadn't even been conceived yet and so wasn't unstable

This explains why I couldn't reproduce it, since the first thing I did was try to build regex using 1.28.0.

This should be fixed in regex 1.3.9 on crates.io.

@goffrie
Copy link
Contributor Author

goffrie commented May 29, 2020

Thanks!

This was referenced Nov 19, 2020
Closed
Closed
@taiki-e taiki-e mentioned this issue Dec 5, 2020
Merged
bors bot added a commit to taiki-e/cargo-hack that referenced this issue Dec 5, 2020
@bors @taiki-e
Merge #102
65b3653 
102: Add --version-range option r=taiki-e a=taiki-e

Closes #93
> This may be useful for catching issues like BurntSushi/termcolor#35, rust-lang/regex#685, rayon-rs/rayon#761 (comment), rust-lang/rust-clippy#6324.

```text
--version-range <START>..[END]
    Perform commands on a specified (inclusive) range of Rust versions.

    If the given range is unclosed, the latest stable compiler is treated as the upper bound.

    Note that ranges are always inclusive ranges.

--version-step <NUM>
    Specify the version interval of --version-range.
```


Note: Ranges are always **inclusive** ranges. (`start..=end`)

```console
$ cargo hack check --version-range 1.46..1.47
info: running `cargo +1.46 check` on cargo-hack (1/2)
    Finished dev [unoptimized + debuginfo] target(s) in 0.28s
info: running `cargo +1.47 check` on cargo-hack (2/2)
    Finished dev [unoptimized + debuginfo] target(s) in 0.23s
```

If the given range is unclosed, the latest stable compiler is treated as the upper bound.

```console
$ cargo hack check --version-range 1.46..
info: running `cargo +1.46 check` on cargo-hack (1/3)
    Finished dev [unoptimized + debuginfo] target(s) in 0.28s
info: running `cargo +1.47 check` on cargo-hack (2/3)
    Finished dev [unoptimized + debuginfo] target(s) in 0.23s
info: running `cargo +1.48 check` on cargo-hack (3/3)
    Finished dev [unoptimized + debuginfo] target(s) in 0.28
```

You can also specify the version interval by using `--version-step`. (`(start..=end).step_by(step)`)

```console
$ cargo hack check --version-range 1.45.. --version-step 2
info: running `cargo +1.45 check` on cargo-hack (1/2)
    Finished dev [unoptimized + debuginfo] target(s) in 0.29s
info: running `cargo +1.47 check` on cargo-hack (2/2)
    Finished dev [unoptimized + debuginfo] target(s) in 0.25s
```

Co-authored-by: Taiki Endo <te316e89@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BurntSushi @goffrie