-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Ergonomic format_args! #1618
Ergonomic format_args! #1618
Conversation
Thanks for the PR and RFC! I personally feel like this change would largely just be a bug fix so it may not require an RFC, but we can probably reach a conclusion in the libs team pretty quickly regardless. |
🔔 This RFC is now entering its week-long final comment period 🔔 The libs team at triage was at least all in favor of this, seems like a great with with no downsides! |
Ok, the libs team got a chance to discuss this RFC yesterday and the conclusion was that we'd like to merge. The RFC, however, may be going a bit too much into detail of how the implementation works (and is maybe even out of date already?). @xen0n would you be ok updating the text to explain mostly at a high level what's happening here? Basically just that |
@alexcrichton Sure, will update the text later. It's a bit late here. 😄 |
* feature name seems not applicable as this is not something to be gated * updated to reflect latest implementation * removed most details for higher-level overview * reworded slightly
Awesome, thanks again @xen0n! |
Rendered.
This describes rust-lang/rust#33642 (minus the TODO bits of course). Hopefully the distinction of macro arguments, placeholders and generated argument objects is made clear...
Note: My native language is not English, so although I've already proofread the draft please do note any English-related issues as well for minimizing confusion.