Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Inline assembly #2873

Merged
merged 68 commits into from
Jul 20, 2020
Merged

Inline assembly #2873

merged 68 commits into from
Jul 20, 2020

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Mar 3, 2020 •
edited by mbrubeck
Loading

A redesigned asm! macro, with a path to stabilization.

Rendered

Implementation PR

This thread is a continuation of #2850, which has grown rather large. All of the feedback from the previous thread has been incorporated in the RFC.

Amanieu added 29 commits January 13, 2020 08:28
@Amanieu
Add inline asm RFC
5559913
@Amanieu
Minor corrections
4edab76
@Amanieu
More minor corrections
03f22fe
@Amanieu
Oops
31cab5e
@Amanieu
Add a section on rules for inline asm
add2123
@Amanieu
Rename flags() to options()
fad338a
@Amanieu
Clarify support for non-LLVM backends
806228f
@Amanieu
Clarify reg class under ARM Thumb1
fa90ad2
@Amanieu
Clarify rules
fc99a8c
@Amanieu
Rename imm to const
2572476
@Amanieu
Rework register classes and modifiers
93b179c
@Amanieu
Fix minor typos
d82b70d
@Amanieu
Disallow specifying the same register as both an input and an output …
2adfde8 
…(use inout instead)
@Amanieu
Clarify implicit operands that come after named operands
89cbf28
@Amanieu
Expand on default modifier used for registers
5884b7f
@Amanieu
Explicit register operands can't be used in the template
f427d17
@Amanieu
Add rationale for not supporting AT&T syntax
feecfa1
@Amanieu
Add rationale for not validating the generating asm in rustc.
15c7aa8
@Amanieu
Remove restriction on sym needing to be from current crate.
7d066ce
@Amanieu
Fix typos
44853af
@Amanieu
Fix some details to match WIP implementation
b5d854d
@Amanieu
Clarify that the compiler must treat asm! as a black box
6b3a129
@Amanieu
Add more examples of asm! usage to motivation
d83a1e1
@Amanieu
Add type whitelist for each register class
904b71e
@Amanieu
Fix typo
a48259d
@Amanieu
x[16-31] don't exist on RV32E
843b6cf
@Amanieu
Clarify rules
a1467e2
@Amanieu
Pointers are i16 on some targets
0f4ffff
@Amanieu
Update semantics of "pure" option
8c54738
@Amanieu Amanieu mentioned this pull request Mar 3, 2020
Closed
anp
anp reviewed Jul 1, 2020
View reviewed changes
text/0000-inline-asm.md
```

Note that the `fn` or `static` item does not need to be public or `#[no_mangle]`:
the compiler will automatically insert the appropriate mangled symbol name into the assembly code.
Copy link
Member

@anp anp Jul 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another note here re: rust-lang/rust#73911 that #[track_caller] functions refer to an indirect shim?

@vlad20012 vlad20012 mentioned this pull request Jul 3, 2020
Open
@Lokathor Lokathor mentioned this pull request Jul 6, 2020
Closed
@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this RFC. label Jul 9, 2020
@rfcbot
Copy link
Collaborator

rfcbot commented Jul 9, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot removed the final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. label Jul 9, 2020
onehr added a commit to onehr/core-os-riscv that referenced this pull request Jul 10, 2020
@onehr
Replace legacy asm! macro with llvm_asm!
1551b08 
From [RFC 2873](rust-lang/rfcs#2873):

> The existing `asm!` macro will be renamed to `llvm_asm!` to provide an
easy way to maintain backwards-compatibility with existing code using
inline asm.
@onehr onehr mentioned this pull request Jul 10, 2020
Merged
@nikomatsakis nikomatsakis merged commit 1660857 into rust-lang:master Jul 20, 2020
@nikomatsakis
Copy link
Contributor

Huzzah! The @rust-lang/lang team has decided to accept this RFC. You can follow along at the following places:

jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 25, 2020
@jlb6740
Update to use the now legacy format by using llvm_asm
e8d61b3 
https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 25, 2020
@jlb6740
Update to use the now legacy format by using llvm_asm
6ac95f9 
https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 25, 2020
@jlb6740
Update to use the now legacy format by using llvm_asm
f7945d5 
https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 25, 2020
@jlb6740
Update to use the now legacy format by using llvm_asm
451b715 
https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 25, 2020
@jlb6740
Update to use the now legacy format by using llvm_asm
249cbbe 
https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 25, 2020
@jlb6740
Update to use the now legacy format by using llvm_asm
d24d315 
https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 25, 2020
@jlb6740
Update to use the now legacy format by using llvm_asm
eac5ac4 
https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 25, 2020
@jlb6740
Update to use the now legacy format by using llvm_asm
45e950a 
https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 25, 2020
@jlb6740
Update to use the now legacy format by using llvm_asm
951c569 
https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 26, 2020
@jlb6740
Update asm to use the new format for inline assembly.
97640d0 
Also adds Arm support

https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 26, 2020
@jlb6740
Update asm to use the new format for inline assembly.
76d2a9b 
Also adds Arm support

https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 26, 2020
@jlb6740
Update asm to use the new format for inline assembly.
389614e 
Also adds Arm support

https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 26, 2020
@jlb6740
Update asm to use the new format for inline assembly.
f4acfd7 
Also adds Arm support

https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 26, 2020
@jlb6740
Update asm to use the new format for inline assembly.
004571c 
Also adds Arm support

https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 26, 2020
@jlb6740
Update inline assembly for x86 to support new syntax
0a94c63 
https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jlb6740 added a commit to jlb6740/rust-precision that referenced this pull request Jul 26, 2020
@jlb6740
Update inline assembly for x86 to support new syntax
0aaa5ac 
https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873
jedisct1 pushed a commit to jedisct1/rust-precision that referenced this pull request Jul 26, 2020
@jlb6740
Update inline assembly to support new syntax (#2)
c9f2bce 
* Update inline assembly for x86 to support new syntax

https://github.com/rust-lang/rfcs/blob/master/text/2843-llvm-asm.md
rust-lang/rfcs#2873

* Add support for Arm
@nomeata nomeata mentioned this pull request Sep 2, 2020
Merged
@phil-opp phil-opp mentioned this pull request Jan 17, 2021
Closed
@jkcoxson jkcoxson mentioned this pull request Jan 28, 2022
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rpjohnst rpjohnst rpjohnst left review comments

@joshtriplett joshtriplett joshtriplett left review comments

@pnkfelix pnkfelix pnkfelix left review comments

@RalfJung RalfJung RalfJung left review comments

@roblabla roblabla roblabla left review comments

@jethrogb jethrogb jethrogb left review comments

@Aaron1011 Aaron1011 Aaron1011 left review comments

@dzamlo dzamlo dzamlo left review comments

@amosonn amosonn amosonn left review comments

@laizy laizy laizy left review comments

@recmo recmo recmo left review comments

@programmerjake programmerjake programmerjake left review comments

@petrochenkov petrochenkov petrochenkov left review comments

@cramertj cramertj cramertj left review comments

@CAD97 CAD97 CAD97 left review comments

@anp anp anp left review comments

@imtsuki imtsuki imtsuki left review comments

@Coder-256 Coder-256 Coder-256 left review comments

@bjorn3 bjorn3 bjorn3 left review comments

Assignees
No one assigned
Labels
A-ASM Proposals related to embedding assemly into Rust. disposition-merge This RFC is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this RFC. T-lang Relevant to the language team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.