Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

RFC: Add String::leak #3317

Closed
wants to merge 4 commits into from
Closed

RFC: Add String::leak #3317

wants to merge 4 commits into from

Conversation

finnbear
Copy link

@finnbear finnbear commented Sep 18, 2022 •
edited
Loading

@thomcc
Copy link
Member

thomcc commented Sep 18, 2022

The right process for this was likely an ACP rather than an RFC, see https://std-dev-guide.rust-lang.org/feature-lifecycle/api-change-proposals.html for more info. While going through an RFC is possible, it's probably overkill for something like this. You probably should file one here: https://github.com/rust-lang/libs-team/issues/new?assignees=&labels=api-change-proposal%2C+T-libs-api&template=api-change-proposal.md&title=%28My+API+Change+Proposal%29 (unless going through the full RFC process sounds better to you...)

@thomcc thomcc added the T-libs-api Relevant to the library API team, which will review and decide on the RFC. label Sep 18, 2022
@finnbear
Copy link
Author

finnbear commented Sep 18, 2022 •
edited
Loading

The right process for this was likely an ACP rather than an RFC

Oh, alright, thanks for letting me know. I'll go submit an ACP :)

Edit: here it is: rust-lang/libs-team#109

@finnbear finnbear closed this Sep 18, 2022
@finnbear finnbear mentioned this pull request Sep 18, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
T-libs-api Relevant to the library API team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finnbear @thomcc