-
Notifications
You must be signed in to change notification settings - Fork 1.6k
RFC: Deprecate std::fmt::format in favor of String::format #810
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
- Start Date: 2015-02-04 | ||
- RFC PR: (leave this empty) | ||
- Rust Issue: (leave this empty) | ||
|
||
# Summary | ||
|
||
Deprecate `std::fmt::format` (to be removed before 1.0) in favor of `String::format`. | ||
|
||
# Motivation | ||
|
||
It's available with libstd or just with libcollections. Also, it's a more | ||
descriptive name; it says what you get. | ||
|
||
# Detailed design | ||
|
||
What it says on the tin. | ||
|
||
There's no visible change for users of the `format!` macro. | ||
|
||
# Drawbacks | ||
|
||
None! Perfect RFC! | ||
|
||
# Alternatives | ||
|
||
Do nothing. In [#21912](https://github.com/rust-lang/rust/pull/21912) I made | ||
`std::fmt::format` a re-export of `collections::fmt::format`, which solved the | ||
problem with `format!` in `no_std` crates. So this RFC is not a high priority, | ||
but still seems like a clear improvement to the language. | ||
|
||
# Unresolved questions | ||
|
||
None! Perfect RFC! |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1