Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Update Racer and Rustfmt #1123

Merged
merged 4 commits into from
Nov 16, 2018
Merged

Update Racer and Rustfmt #1123

merged 4 commits into from
Nov 16, 2018

Conversation

Xanewok
Copy link
Member

@Xanewok Xanewok commented Nov 15, 2018

Needs a Racer release including the racer-rust/racer#1000
cc @kngwyu

@nrc this has the remaining impls. Still fails on:

failures:

---- test::test_goto_def stdout ----
thread 'test::test_goto_def' panicked at 'Assert failed: Could not find `"start":{"line":20,"character":8}` in `{"jsonrpc":"2.0","id":11,"result":[]}`', src/test/harness.rs:227:9

---- test::test_hover stdout ----
thread 'test::test_hover' panicked at 'Assert failed: Could not find `[{"language":"rust","value":"&str"},{"language":"rust","value":"let world = \"world\";"}]` in `{"jsonrpc":"2.0","id":11,"result":{"contents":[]}}`', src/test/harness.rs:227:9

---- test::test_highlight stdout ----
thread 'test::test_highlight' panicked at 'Assert failed: Could not find `{"start":{"line":20,"character":8},"end":{"line":20,"character":13}}` in `{"jsonrpc":"2.0","id":42,"result":[]}`', src/test/harness.rs:227:9

---- test::test_rename stdout ----
thread 'test::test_rename' panicked at 'Assert failed: Could not find `{"start":{"line":20,"character":8},"end":{"line":20,"character":13}}` in `{"jsonrpc":"2.0","id":42,"result":{}}`', src/test/harness.rs:227:9


failures:
    test::test_goto_def
    test::test_highlight
    test::test_hover
    test::test_rename

but that's until rust-lang/rust#55936 lands, right?

nrc and others added 3 commits November 15, 2018 22:46
Deduplicates `rustc-ap-*` and uses the v297 version of the libraries instead.
For now this pulls Racer from git to include the
racer-rust/racer#1000.
@@ -219,6 +219,11 @@ pub fn completion_kind_from_match_type(m: racer::MatchType) -> CompletionItemKin
| racer::MatchType::Static => CompletionItemKind::Variable,
racer::MatchType::TypeParameter(_) => CompletionItemKind::TypeParameter,
racer::MatchType::Builtin(_) => CompletionItemKind::Keyword,
racer::MatchType::UseAlias(m) => match m.mtype {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kngwyu do I understand that in this case, we have use X as Y and we match on Y but m here refers to X and we can derive the completion kind from that instead? (also nested/recursive case seems to be impossible?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's impossible too but haven't tested it yet.

@Xanewok
Copy link
Member Author

Xanewok commented Nov 16, 2018

All tests pass locally with Rust with rust-lang/rust#55936 applied 🎉

Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@nrc nrc merged commit 7b7ec0e into master Nov 16, 2018
@Xanewok Xanewok deleted the racer-update branch June 30, 2019 15:59
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants