Can't shadow built-in attributes

[flodiebold]

In the following code:

use tokio::main;

#[main]
async fn foo() {
}

we resolve main as the built-in attribute instead of tokio::main.

I tried to look into this, but actually failed to understand how we resolve built-in attributes during item collection at all 🤔

[flodiebold]

Aah, we skip them here:

rust-analyzer/crates/hir-def/src/nameres/collector.rs

Lines 1865 to 1867 in 6407727

	if self.def_collector.def_map.is_builtin_or_registered_attr(&attr.path) {
	continue;
	}

and so never see them later in resolve_macros.

[ajf-sa]

Aah, when I update my rust-analyzer to last version in windows -PC the error gone !, but still get error in MacoOS m1 system

[flodiebold]

For the M1 system, you need to make sure that you've installed the arm64 toolchain with rustup, by doing something like rustup toolchain default stable-aarch64.

[ajf-sa]

that fix my issue thanks :) rustup default stable-aarch64-apple-darwin

[Veykril]

#12690 removes main from the inert attribute list as the rustc repo doesn't list it anymore either. Can we consider this fixed? I was a bit confused to even see rust accept this since shadowing builtin attributes usually result in an ambiguity error, but not for main apparently?

[lnicola]

Seems fixed now, at least for main. I think we can close it for now.