Skip to content

Remove handling of #[rustc_deprecated] #11983

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 9, 2022
Merged

Remove handling of #[rustc_deprecated] #11983

merged 1 commit into from
May 9, 2022

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Apr 14, 2022

This should be merged along with rust-lang/rust#95960.

Because the attribute still exists in rustc, I've left the definition here. With that said, any use of it is an error, so I've removed any handling of #[rustc_deprecated].

@lnicola
Copy link
Member

lnicola commented Apr 14, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Apr 14, 2022

📌 Commit 5ca9ffe has been approved by lnicola

@jhpratt
Copy link
Member Author

jhpratt commented Apr 14, 2022

While I appreciate the quick r+, I think this should wait until the aforementioned PR lands :)

@lnicola
Copy link
Member

lnicola commented Apr 14, 2022

@bors r-

@lnicola
Copy link
Member

lnicola commented Apr 14, 2022

I wanted to merge it directly because it's only a cosmetic issue, but sure :-).

@jhpratt
Copy link
Member Author

jhpratt commented Apr 14, 2022

I mean, it's up to you 🤷 It's just that until that PR lands, whether something from stdlib is deprecated would be wrong. Which should be a short amount of time, but nonetheless.

@bors
Copy link
Contributor

bors commented May 1, 2022

☔ The latest upstream changes (presumably #12118) made this pull request unmergeable. Please resolve the merge conflicts.

@lnicola
Copy link
Member

lnicola commented May 9, 2022

@bors r+

@bors
Copy link
Contributor

bors commented May 9, 2022

📌 Commit 3c376e5 has been approved by lnicola

@bors
Copy link
Contributor

bors commented May 9, 2022

⌛ Testing commit 3c376e5 with merge 3d2d209...

@bors
Copy link
Contributor

bors commented May 9, 2022

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 3d2d209 to master...

@bors bors merged commit 3d2d209 into rust-lang:master May 9, 2022
@jhpratt jhpratt deleted the remove-rustc_deprecated branch May 9, 2022 13:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants