Skip to content

Turn let-else statements into let and match #12130

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
May 17, 2022

Conversation

weirane
Copy link
Contributor

@weirane weirane commented May 1, 2022

Fixes #11906.

@bors
Copy link
Contributor

bors commented May 1, 2022

☔ The latest upstream changes (presumably #12118) made this pull request unmergeable. Please resolve the merge conflicts.

@weirane weirane force-pushed the let-else-let-match branch from 60fed92 to 59cdb31 Compare May 1, 2022 16:46
@weirane weirane force-pushed the let-else-let-match branch from f875d05 to a70beea Compare May 2, 2022 22:20
@weirane weirane force-pushed the let-else-let-match branch from 4059fa1 to 8d7a393 Compare May 5, 2022 18:44
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for taking this long to get back to this. Looks good to me with one small nit left. Thanks!

@bors delegate+

@Veykril
Copy link
Member

Veykril commented May 17, 2022

@bors delegate+

@bors
Copy link
Contributor

bors commented May 17, 2022

✌️ @weirane can now approve this pull request

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
@weirane weirane force-pushed the let-else-let-match branch from 0d3d520 to 4a0821f Compare May 17, 2022 18:45
@weirane
Copy link
Contributor Author

weirane commented May 17, 2022

@bors r+

@bors
Copy link
Contributor

bors commented May 17, 2022

📌 Commit 4a0821f has been approved by weirane

@bors
Copy link
Contributor

bors commented May 17, 2022

⌛ Testing commit 4a0821f with merge 187bd7d...

@weirane
Copy link
Contributor Author

weirane commented May 17, 2022

Thanks for the suggestions!

@bors
Copy link
Contributor

bors commented May 17, 2022

☀️ Test successful - checks-actions
Approved by: weirane
Pushing 187bd7d to master...

@bors bors merged commit 187bd7d into rust-lang:master May 17, 2022
@weirane weirane deleted the let-else-let-match branch May 17, 2022 19:12
@lnicola
Copy link
Member

lnicola commented May 23, 2022

let-else.mp4

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add assist to turn let-else statements into let statements + match expression
5 participants