Add fixups for incomplete in proc-macros #12937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the changes are failing Tidy (they pass everything else). I'm getting this diff, but the +/- lines look exactly the same to me 😅 EDIT: Now I see, Tidy changed the code, and it should pass now! |
Veykril
reviewed
Aug 4, 2022
Previously added a blank _ => {} for match statements
|
Thanks! |
|
☀️ Test successful - checks-actions |
|
changelog fix (first contribution) implement syntax fix-up for |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #12777.
Added support for for loops and match statements.
I couldn't do paths like
crate::foo::as I wasn't able to addSyntheticTokensto the end offoo::, they always ended up aftercrate::This is my first contribution so please don't be shy about letting me know if I've done anything wrong!