Skip to content

Add bounds for fields in derive macro #14521

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Add bounds for fields in derive macro #14521

merged 1 commit into from
Apr 7, 2023

Conversation

HKalbasi
Copy link
Member

@HKalbasi HKalbasi commented Apr 6, 2023

Dependency of #14470

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2023
@Veykril
Copy link
Member

Veykril commented Apr 7, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 7, 2023

📌 Commit 0241b52 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 7, 2023

⌛ Testing commit 0241b52 with merge 937ef97...

@bors
Copy link
Contributor

bors commented Apr 7, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 937ef97 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 7, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 937ef97 to master...

@bors
Copy link
Contributor

bors commented Apr 7, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors bors merged commit 937ef97 into rust-lang:master Apr 7, 2023
@Veykril
Copy link
Member

Veykril commented Apr 7, 2023

This brought us from 1 to 50 type mismatches and for ripgrep from 0 to 2

bors added a commit that referenced this pull request Apr 7, 2023
Revert "Add bounds for fields in derive macro"

Reverts #14521 as it introduces too many mismatches
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants