Skip to content

internal: Replace format-args parser with upstream fork #15568

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Sep 7, 2023

Turns out we can't bump rustc_abi right now because it got its generics removed accidentally rust-lang/rust#107163

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2023
@Veykril
Copy link
Member Author

Veykril commented Sep 7, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Sep 7, 2023

📌 Commit 10b0cd7 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 7, 2023

⌛ Testing commit 10b0cd7 with merge 8edd81f...

@Veykril
Copy link
Member Author

Veykril commented Sep 7, 2023

well thats annoying, upstream changed things so much since thats its non trivial to update

@bors
Copy link
Contributor

bors commented Sep 7, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 8edd81f to master...

@bors bors merged commit 8edd81f into rust-lang:master Sep 7, 2023
@Veykril Veykril deleted the upstream-rustc-ap branch September 7, 2023 10:13
@lnicola lnicola changed the title Replace format-args parser with upstream fork internal: Replace format-args parser with upstream fork Sep 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants